Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move rsonpath-benchmarks as a full subdirectory #549

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

V0ldek
Copy link
Member

@V0ldek V0ldek commented Oct 25, 2024

Short description

We used submodules to separate rsonpath-benchmarks from rsonpath but that is no longer useful. Since rsonpath-benchmarks needs to be updated every time rsonpath is, and we want to run benchmarks every time we update rsonpath, they are very much tied together. It remains separate from the main rsonpath workspace, though, as its dependencies are completely separate.

Issue

Resolves: #543

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

We used submodules to separate rsonpath-benchmarks from rsonpath
but that is no longer useful. Since rsonpath-benchmarks needs to be updated
every time rsonpath is, and we want to run benchmarks every time we update rsonpath,
they are very much tied together. It remains separate from the main rsonpath
workspace, though, as its dependencies are completely separate.
@V0ldek V0ldek force-pushed the v0ldek/integrate-benchmarks branch from 395a7e7 to 8d9bebd Compare October 25, 2024 18:42
@V0ldek V0ldek force-pushed the v0ldek/integrate-benchmarks branch from 2ce6edc to d1a279e Compare October 25, 2024 19:19
@V0ldek V0ldek merged commit ac85aee into main Oct 25, 2024
50 checks passed
@V0ldek V0ldek deleted the v0ldek/integrate-benchmarks branch October 25, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot failure and lesser issues
1 participant