move rsonpath-benchmarks as a full subdirectory #549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
We used submodules to separate rsonpath-benchmarks from rsonpath but that is no longer useful. Since rsonpath-benchmarks needs to be updated every time rsonpath is, and we want to run benchmarks every time we update rsonpath, they are very much tied together. It remains separate from the main rsonpath workspace, though, as its dependencies are completely separate.
Issue
Resolves: #543
Checklist
All of these should be ticked off before you submit the PR.
just verify
locally and it succeeded.